netdev - Re: [PATCH net-next v5 12/21] switchdev: remove old switchdev_port_bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150507153637.GB2121@nanopsycho>
Date:	Thu, 7 May 2015 17:36:38 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	sfeldma@...il.com
Cc:	netdev@...r.kernel.org, roopa@...ulusnetworks.com,
	linux@...ck-us.net, f.fainelli@...il.com,
	sridhar.samudrala@...el.com, ronen.arad@...el.com, andrew@...n.ch,
	simon.horman@...ronome.com
Subject: Re: [PATCH net-next v5 12/21] switchdev: remove old
 switchdev_port_bridge_setlink

Tue, May 05, 2015 at 07:34:48PM CEST, sfeldma@...il.com wrote:
>From: Scott Feldman <sfeldma@...il.com>
>
>New attr-based bridge_setlink can recurse lower devs and recover on err, so
>remove old wrapper.  Also, restore br_setlink back to original and don't
>call into SELF port driver.  rtnetlink.c:bridge_setlink already does a call
>into port driver for SELF.
>
>Signed-off-by: Scott Feldman <sfeldma@...il.com>
>---
> include/net/switchdev.h   |   17 -----------------
> net/bridge/br_netlink.c   |   11 +----------
> net/switchdev/switchdev.c |   30 ------------------------------
> 3 files changed, 1 insertion(+), 57 deletions(-)
>
>diff --git a/include/net/switchdev.h b/include/net/switchdev.h
>index aa6c370..ce5ceb2 100644
>--- a/include/net/switchdev.h
>+++ b/include/net/switchdev.h
>@@ -122,8 +122,6 @@ int switchdev_port_attr_set(struct net_device *dev,
> 			    struct switchdev_attr *attr);
> int switchdev_port_obj_add(struct net_device *dev, struct switchdev_obj *obj);
> int switchdev_port_obj_del(struct net_device *dev, struct switchdev_obj *obj);
>-int switchdev_port_bridge_setlink(struct net_device *dev, struct nlmsghdr *nlh,
>-			      u16 flags);

I don't understand why you remove this. Would for example bond compile
after this? 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html