lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 8 May 2015 18:46:47 +0200 From: Andrew Lunn <andrew@...n.ch> To: Bert Vermeulen <bert@...t.com> Cc: f.fainelli@...il.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net: mdio-gpio: Allow for unspecified bus id > >> - snprintf(new_bus->id, MII_BUS_ID_SIZE, "gpio-%x", bus_id); > >> + if (bus_id != -1) > >> + snprintf(new_bus->id, MII_BUS_ID_SIZE, "gpio-%x", bus_id); > >> + else > >> + strncpy(new_bus->id, "gpio", MII_BUS_ID_SIZE); > > > > Hi Bert > > > > What happens if there are multiple platform_device's with -1? You > > should probably be using use idr_alloc(). > > It's an instance id per driver, not globally, and -1 specifically means it's > the only instance. From Documentation/driver-model/platform.txt: Ah, did not know there can only be one with -1. I've used i2c where this does not apply when registering adaptors. It will allocate a unique id to each added with id = -1. Andrew -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists