netdev - Re: [PATCH] net: mdio-gpio: Allow for unspecified bus id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150508164917.GL18496@lunn.ch>
Date:	Fri, 8 May 2015 18:49:17 +0200
From:	Andrew Lunn <andrew@...n.ch>
To:	Bert Vermeulen <bert@...t.com>
Cc:	f.fainelli@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: mdio-gpio: Allow for unspecified bus id

On Fri, May 08, 2015 at 04:18:49PM +0200, Bert Vermeulen wrote:
> When the bus id was supplied via a struct platform_device, the driver wasn't
> handling -1 to mean an unspecified id of the only instance of this driver,
> as the platform spec requires.
> 
> Signed-off-by: Bert Vermeulen <bert@...t.com>
> ---
>  drivers/net/phy/mdio-gpio.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/mdio-gpio.c
> index f5cddf5..7bd90db 100644
> --- a/drivers/net/phy/mdio-gpio.c
> +++ b/drivers/net/phy/mdio-gpio.c
> @@ -165,7 +165,10 @@ static struct mii_bus *mdio_gpio_bus_init(struct device *dev,
>  		if (!new_bus->irq[i])
>  			new_bus->irq[i] = PHY_POLL;
>  
> -	snprintf(new_bus->id, MII_BUS_ID_SIZE, "gpio-%x", bus_id);
> +	if (bus_id != -1)
> +		snprintf(new_bus->id, MII_BUS_ID_SIZE, "gpio-%x", bus_id);
> +	else
> +		strncpy(new_bus->id, "gpio", MII_BUS_ID_SIZE);
>  
>  	if (devm_gpio_request(dev, bitbang->mdc, "mdc"))
>  		goto out_free_bus;
> -- 

Reviewed-by: Andrew Lunn <andrew@...n.ch>

Andrew
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html