netdev - Re: [PATCH] iproute2: GENEVE support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEP_g=_-3K7O3MA=nCBjO7PZUGAj0HQd8=YchQ89jq-U3mUwtg@mail.gmail.com>
Date:	Fri, 8 May 2015 16:27:56 -0700
From:	Jesse Gross <jesse@...ira.com>
To:	"John W. Linville" <linville@...driver.com>
Cc:	netdev <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Andy Zhou <azhou@...ira.com>,
	Stephen Hemminger <stephen@...workplumber.org>,
	Alexander Duyck <alexander.h.duyck@...hat.com>
Subject: Re: [PATCH] iproute2: GENEVE support

On Fri, May 8, 2015 at 10:27 AM, John W. Linville
<linville@...driver.com> wrote:
> diff --git a/ip/iplink_geneve.c b/ip/iplink_geneve.c
> new file mode 100644
> index 000000000000..74703e1ee156
> --- /dev/null
> +++ b/ip/iplink_geneve.c
> +static int geneve_parse_opt(struct link_util *lu, int argc, char **argv,
> +                         struct nlmsghdr *n)
> +{
[...]
> +               } else if (!matches(*argv, "remote")) {
> +                       NEXT_ARG();
> +                       if (!inet_get_addr(*argv, &daddr, &daddr6)) {
> +                               fprintf(stderr, "Invalid address \"%s\"\n", *argv);
> +                               return -1;
> +                       }
> +                       if (IN_MULTICAST(ntohl(daddr)))
> +                               invarg("invalid remote address", *argv);

We should probably validate the no multicast check in the kernel as
well since it won't do the right thing anyways.

[...]
> +       if (!daddr) {
> +               fprintf(stderr, "geneve: remove link partner not specified\n");
> +               return -1;
> +       }
> +       if (memcmp(&daddr6, &in6addr_any, sizeof(daddr6)) != 0) {
> +               fprintf(stderr, "geneve: remove link over IPv6 not supported\n");
> +               return -1;
> +       }

Two typos in the above strings - "remove" instead of "remote".
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html