netdev - Re: [PATCH] netxen_nic: use spin_[un]lock_bh around tx_clean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150509.164512.2163013950829969411.davem@davemloft.net>
Date:	Sat, 09 May 2015 16:45:12 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	tcamuso@...hat.com
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	manish.chopra@...gic.com, sony.chacko@...gic.com,
	rajesh.borundia@...gic.com, nhorman@...hat.com
Subject: Re: [PATCH] netxen_nic: use spin_[un]lock_bh around tx_clean_lock
 (2)

From: Tony Camuso <tcamuso@...hat.com>
Date: Wed,  6 May 2015 09:09:18 -0400

> This patch should have been part of the previous patch having the
> same summary. See  http://marc.info/?l=linux-kernel&m=143039470103795&w=2
> Unfortunately, I didn't check to see where else this lock was used before
> submitting that patch. This should take care of it for netxen_nic, as I
> did a thorough search this time.
> 
> To recap from the original patch; although testing this driver with
> DEBUG_LOCKDEP and DEBUG_SPINLOCK enabled did not produce any traces,
> it would be more prudent in the case of tx_clean_lock to use _bh
> versions of spin_[un]lock, since this lock is manipulated in both
> the process and softirq contexts.
> 
> This patch was tested for functionality and regressions with netperf
> and DEBUG_LOCKDEP and DEBUG_SPINLOCK enabled.
> 
> Signed-off-by: Tony Camuso <tcamuso@...hat.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html