netdev - Re: [PATCH] usbnet: avoid integer overflow in start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150509.164635.1141216772229266057.davem@davemloft.net>
Date:	Sat, 09 May 2015 16:46:35 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	Jason@...c4.com
Cc:	oneukum@...e.de, netdev@...r.kernel.org
Subject: Re: [PATCH] usbnet: avoid integer overflow in start_xmit

From: "Jason A. Donenfeld" <Jason@...c4.com>
Date: Wed,  6 May 2015 15:09:40 +0200

> transfer_buffer_length is of type u32. It's therefore wrong to assign it
> to a signed integer. This patch avoids the overflow.
> 
> It's worth noting that entry->length here is a long; perhaps it would be
> beneficial at somepoint to change this to be unsigned as well, if
> nothing else relies on its signedness for error conditions or the like.
> 
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html