netdev - Re: [PATCH] net: Remove remaining remnants of pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 11 May 2015 11:27:22 -0600
From:	David Ahern <dsahern@...il.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org, tgraf@...g.ch
Subject: Re: [PATCH] net: Remove remaining remnants of pm_qos from netdevice.h

On 5/11/15 11:26 AM, David Miller wrote:
> From: David Miller <davem@...emloft.net>
> Date: Mon, 11 May 2015 13:11:06 -0400 (EDT)
>
>> From: David Ahern <dsahern@...il.com>
>> Date: Sat,  9 May 2015 16:21:43 -0600
>>
>>> Commit e2c6544829f removed pm_qos from struct net_device but left the
>>> comment above header file. Remove those.
>>>
>>> Signed-off-by: David Ahern <dsahern@...il.com>
>>
>> Applied, thanks David.
>
> Actually I had to revert as this breaks the build.
>
> You will need to submit another patch with this one, one that adds an
> include of <linux/pm_qos.h> to drivers/net/ethernet/intel/e1000e/e1000.h
>
> In file included from drivers/net/ethernet/intel/e1000e/82571.c:38:0:
> drivers/net/ethernet/intel/e1000e/e1000.h:346:24: error: field ‘pm_qos_req’ has incomplete type
>    struct pm_qos_request pm_qos_req;
>                          ^
>

crap. I did a VM build with virtio only. Will redo.

David
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html