netdev - Re: [PATCH] net: Remove remaining remnants of pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150511.132611.701878238281798138.davem@davemloft.net>
Date:	Mon, 11 May 2015 13:26:11 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dsahern@...il.com
Cc:	netdev@...r.kernel.org, tgraf@...g.ch
Subject: Re: [PATCH] net: Remove remaining remnants of pm_qos from
 netdevice.h

From: David Miller <davem@...emloft.net>
Date: Mon, 11 May 2015 13:11:06 -0400 (EDT)

> From: David Ahern <dsahern@...il.com>
> Date: Sat,  9 May 2015 16:21:43 -0600
> 
>> Commit e2c6544829f removed pm_qos from struct net_device but left the
>> comment above header file. Remove those.
>> 
>> Signed-off-by: David Ahern <dsahern@...il.com>
> 
> Applied, thanks David.

Actually I had to revert as this breaks the build.

You will need to submit another patch with this one, one that adds an
include of <linux/pm_qos.h> to drivers/net/ethernet/intel/e1000e/e1000.h

In file included from drivers/net/ethernet/intel/e1000e/82571.c:38:0:
drivers/net/ethernet/intel/e1000e/e1000.h:346:24: error: field ‘pm_qos_req’ has incomplete type
  struct pm_qos_request pm_qos_req;
                        ^