netdev - Re: [PATCH -next] net: core: set qdisc pkt len before tc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1431440547.566.84.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 12 May 2015 07:22:27 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Florian Westphal <fw@...len.de>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH -next] net: core: set qdisc pkt len before tc_classify

On Tue, 2015-05-12 at 15:37 +0200, Florian Westphal wrote:

> 
> Fixes: d2788d34885d ("net: sched: further simplify handle_ing")
> Acked-by: Daniel Borkmann <daniel@...earbox.net>
> Signed-off-by: Florian Westphal <fw@...len.de>
> ---
>  net/core/dev.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/net/core/dev.c b/net/core/dev.c
> index e5f77c4..871181a 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -3540,8 +3540,9 @@ static inline struct sk_buff *handle_ing(struct sk_buff *skb,
>  		*pt_prev = NULL;
>  	}
>  
> -	qdisc_bstats_update_cpu(cl->q, skb);
> +	qdisc_skb_cb(skb)->pkt_len = skb->len;


A qdisc might have a stab (cf qdisc_calculate_pkt_len() )

>  	skb->tc_verd = SET_TC_AT(skb->tc_verd, AT_INGRESS);
> +	qdisc_bstats_update_cpu(cl->q, skb);
>  
>  	switch (tc_classify(skb, cl, &cl_res)) {
>  	case TC_ACT_OK:


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html