netdev - Re: [PATCH 2/6] net: Add a struct net parameter to sock_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55520AEC.4090500@6wind.com>
Date:	Tue, 12 May 2015 16:15:08 +0200
From:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:	David Laight <David.Laight@...LAB.COM>,
	"'Eric W. Biederman'" <ebiederm@...ssion.com>,
	"davem@...emloft.net" <davem@...emloft.net>
CC:	Ying Xue <ying.xue@...driver.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"cwang@...pensource.com" <cwang@...pensource.com>,
	"xemul@...nvz.org" <xemul@...nvz.org>,
	"eric.dumazet@...il.com" <eric.dumazet@...il.com>,
	"maxk@....qualcomm.com" <maxk@....qualcomm.com>,
	"stephen@...workplumber.org" <stephen@...workplumber.org>,
	"tgraf@...g.ch" <tgraf@...g.ch>,
	"tom@...bertland.com" <tom@...bertland.com>,
	"jchapman@...alix.com" <jchapman@...alix.com>,
	"erik.hugne@...csson.com" <erik.hugne@...csson.com>,
	"jon.maloy@...csson.com" <jon.maloy@...csson.com>,
	"horms@...ge.net.au" <horms@...ge.net.au>,
	Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH 2/6] net: Add a struct net parameter to sock_create_kern

Le 12/05/2015 15:16, David Laight a écrit :
> From: Nicolas Dichtel [mailto:nicolas.dichtel@...nd.com]
>> Sent: 12 May 2015 13:29
>> Le 12/05/2015 13:48, David Laight a écrit :
>>> From: Eric W. Biederman
>>>> Sent: 12 May 2015 09:55
>>>>
>>>> On May 12, 2015 3:24:11 AM CDT, David Laight <David.Laight@...LAB.COM> wrote:
>>> ...
>>>>> Wouldn't it involve far less churn to add a new function that uses a
>>>>> non-default namespace?
>>>>
>>>> The goal is comprehensible and maintainable kernel code.
>>>>
>>>> Which network namespace your socket is in, is an important property and something you probably care
>>>> about if you are creating kernel sockets.
>>>
>>> That rather depends on whether you've anywhere to get a namespace from.
>>> eg something like ceph/messenger.c
>> sk_net(con->sock->sk)?
>
> What if you don't already have a socket?
> Just an IP(v6) address ?
So you have an IPv6 address and you don't know on which netns this address
belongs? I can't imagine how it can work.

>
>> This parameter is essential, hiding it will just hides bugs.
>> Having this parameter forces the developer to ask himself what is the best
>> value.
>
> What if the answer is 'NFI'?
> Which requires the answer be pushed back to the 'application' configuration?
Your application is bound to a netns.

> Most users will have no idea either.
If you support netns, you *have to know*.


Regards,
Nicolas
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html