netdev - Re: [PATCH net-next v2 6/6] packet: rollover statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 May 2015 11:04:19 -0400
From:	Willem de Bruijn <willemb@...gle.com>
To:	David Miller <davem@...emloft.net>
Cc:	Network Development <netdev@...r.kernel.org>,
	Eric Dumazet <eric.dumazet@...il.com>,
	David Laight <david.laight@...lab.com>
Subject: Re: [PATCH net-next v2 6/6] packet: rollover statistics

>>
>> +struct tpacket_rollover_stats {
>> +     unsigned long   tp_all;
>> +     unsigned long   tp_huge;
>> +     unsigned long   tp_failed;
>> +};
>
> Please do not use variably sized types, especially "long" for user exported
> interfaces.  Otherwise you will need to add a compat layer to translate
> the data into userspace for 32-bit tasks running on a 64-bit kernel.
>
> If a 32-bit value really is not sufficient, use __aligned_u64.

Thanks for catching that. I converted them to __aligned_u64. The
internal counters remain atomic_long_t.

I'll push v3 of the patchset with only this change.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html