netdev - Re: [PATCH net v2] rtnl/bond: don't send rtnl msg for unregistered iface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <555216DA.3020105@6wind.com>
Date:	Tue, 12 May 2015 17:06:02 +0200
From:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:	jiri@...nulli.us
CC:	davem@...emloft.net, netdev@...r.kernel.org, j.vosburgh@...il.com,
	vfalico@...il.com, gospo@...ulusnetworks.com
Subject: Re: [PATCH net v2] rtnl/bond: don't send rtnl msg for unregistered
 iface

Le 12/05/2015 17:03, Nicolas Dichtel a écrit :
[snip]
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -3273,7 +3273,8 @@ static int rtnetlink_event(struct notifier_block *this, unsigned long event, voi
>   	case NETDEV_BONDING_INFO:
>   		break;
>   	default:
> -		rtmsg_ifinfo(RTM_NEWLINK, dev, 0, GFP_KERNEL);
> +		if (dev->reg_state == NETREG_REGISTERED)
> +			rtmsg_ifinfo(RTM_NEWLINK, dev, 0, GFP_KERNEL);
In fact, it's probably better to put this in rtmsg_ifinfo().
Will send a v3, sorry for the noise.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html