netdev - Re: [PATCH v2 net-next 0/2] tcp: tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150512222150.GE13809@localhost.localdomain>
Date:	Tue, 12 May 2015 19:21:50 -0300
From:	Marcelo Ricardo Leitner <mleitner@...hat.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Yuchung Cheng <ycheng@...gle.com>,
	Matt Mathis <mattmathis@...gle.com>,
	Craig Gallek <cgallek@...gle.com>, Martin Lau <kafai@...com>,
	Chris Rapier <rapier@....edu>
Subject: Re: [PATCH v2 net-next 0/2] tcp: tcp_info extensions

On Tue, May 12, 2015 at 01:31:53PM -0700, Eric Dumazet wrote:
> On Tue, 2015-05-12 at 10:08 -0300, Marcelo Ricardo Leitner wrote:
> > On Tue, Apr 28, 2015 at 03:28:16PM -0700, Eric Dumazet wrote:
> > > As discussed during Chris Rapier presentation in Ottawa / netdev0.1,
> > > we add to tcp_info the first two fields are highly wanted.
> > > 
> > > Each field is added into a single patch for easy code review.
> > > 
> > > (Corresponding iproute2/ss patches will be sent)
> > > 
> > > Next fields will follow once consensus is reached.
> > 
> > Is tcpEStatsPerfSegsOut amongst them? I have a need for this one and can
> > submit a patch if you're not tracking it already.
> 
> Yes, along with tcpEStatsPerfSegsIn
> 
> Because tcp_info is aligned to 64bits, we cannot cook a patch simply
> adding tcpEStatsPerfSegsOut (u32), otherwise we would introduce a hole.

Oh ok, thanks for pointing this out.

> If you can cook the patch adding tcpEStatsPerfSegsOut and
> tcpEStatsPerfSegsIn, I would be very happy to review it.

Cool, will do it, thanks!

  Marcelo

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html