netdev - Re: [PATCH net-next] net_sched: gred: add TCA_GRED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150512.182311.1437113579733139908.davem@davemloft.net>
Date:	Tue, 12 May 2015 18:23:11 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	david.ward@...mit.edu
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net_sched: gred: add TCA_GRED_LIMIT attribute

From: David Ward <david.ward@...mit.edu>
Date: Sat,  9 May 2015 22:01:46 -0400

> In a GRED qdisc, if the default "virtual queue" (VQ) does not have drop
> parameters configured, then packets for the default VQ are not subjected
> to RED and are only dropped if the queue is larger than the net_device's
> tx_queue_len. This behavior is useful for WRED mode, since these packets
> will still influence the calculated average queue length and (therefore)
> the drop probability for all of the other VQs. However, for some drivers
> tx_queue_len is zero. In other cases the user may wish to make the limit
> the same for all VQs (including the default VQ with no drop parameters).
> 
> This change adds a TCA_GRED_LIMIT attribute to set the GRED queue limit,
> in bytes, during qdisc setup. (This limit is in bytes to be consistent
> with the drop parameters.) The default limit is the same as for a bfifo
> queue (tx_queue_len * psched_mtu). If the drop parameters of any VQ are
> configured with a smaller limit than the GRED queue limit, that VQ will
> still observe the smaller limit instead.
> 
> Signed-off-by: David Ward <david.ward@...mit.edu>

Applied, thanks David.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html