netdev - Re: [PATCH net] netlink: move nl_table in read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150514.174935.933671221344067206.davem@davemloft.net>
Date:	Thu, 14 May 2015 17:49:35 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] netlink: move nl_table in read_mostly section

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 12 May 2015 17:24:50 -0700

> From: Eric Dumazet <edumazet@...gle.com>
> 
> netlink sockets creation and deletion heavily modify nl_table_users
> and nl_table_lock.
> 
> If nl_table is sharing one cache line with one of them, netlink
> performance is really bad on SMP.
> 
> ffffffff81ff5f00 B nl_table
> ffffffff81ff5f0c b nl_table_users
> 
> Putting nl_table in read_mostly section increased performance
> of my open/delete netlink sockets test by about 80 %
> 
> This came up while diagnosing a getaddrinfo() problem.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html