netdev - Re: [PATCH net-next 00/11] convert stmmac glue layers into platform drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5555B832.3080708@st.com>
Date:	Fri, 15 May 2015 11:11:14 +0200
From:	Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	Chen-Yu Tsai <wens@...e.org>,
	Joachim Eastwood <manabian@...il.com>,
	Roger <roger.chen@...k-chips.com>,
	<dinguyen@...nsource.altera.com>, <b.galvani@...il.com>,
	netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	<linux-rockchip@...ts.infradead.org>
Subject: Re: [PATCH net-next 00/11] convert stmmac glue layers into platform
 drivers

Hi Arnd

On 5/15/2015 10:44 AM, Arnd Bergmann wrote:
> On Friday 15 May 2015 09:45:47 Giuseppe CAVALLARO wrote:
>> Hello
>>
>> On 5/14/2015 5:24 PM, Chen-Yu Tsai wrote:
>>> On Thu, May 14, 2015 at 6:10 PM, Joachim Eastwood <manabian@...il.com> wrote:
>>>> This patch set aims to convert the current dwmac glue layers into
>>>> proper platform drivers as request by Arnd[1]. These changes start
>>>> from patch 3 and onwards.
>>>>
>>>> Overview:
>>>> Platform driver functions like probe and remove are exported from
>>>> the stmmac platform and then used in subsequent glue later
>>>> conversions. The conversion involes adding the platform driver
>>>> boiler plate code and adding it to the build system. The last patch
>>>> removes the driver from the stmmac platform code thus making it into
>>>> a library for common platform driver functions.
>>>>
>>>> The two first patches adds glue layer for my platform. I chose to
>>>> first add old style glue layer and then convert it. The churn this
>>>> creates is just 3 lines.
>>>>
>>>> I would be very nice if people could test this patch set on their
>>>> respective platform. My testing has been limited to compiling and
>>>> testing on my (LPC18xx) platform. Thanks!
>>
>> I wonder if this will make the compatibility with old
>> platforms (like SH4) not based on DT, where there was not used
>> any glue-logic around the driver and just the platform was the
>> reference.
>
> With patch 11, this gets handled by the dwmac-generic driver.

ok

>
>> To be honest, I prefer to not have the Kconfig options.
>> The device-tree compatibility will select the glue-logic
>> needed and we will just pay some bytes when compile.
>>
>> In my opinion, the Koption(s) introduce a problem when touch
>> the driver and we want to guarantee that, at least,
>> all its parts build fine on all the platforms.
>
> The current model is not scalable and requires modifying the base
> driver for each variation, and the change brings the driver
> in line with how we do things for other platform drivers.
>
> We should always be able to build all soc-specific glue drivers
> with 'allmodconfig' for build testing, and a lot of us run that
> frequently to find regressions.

thx for your prompt feedback

Peppe

>
> 	Arnd
>
>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html