[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1431771615.1844.4.camel@gmail.com>
Date: Sat, 16 May 2015 06:20:15 -0400
From: "Charles (Chas) Williams" <3chas3@...il.com>
To: David Laight <David.Laight@...LAB.COM>
Cc: "'Jason A. Donenfeld'" <Jason@...c4.com>,
"shigekatsu.tateno@...el.com" <shigekatsu.tateno@...el.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"oss-security@...ts.openwall.com" <oss-security@...ts.openwall.com>
Subject: Re: [PATCH 1/4] ozwpan: Use proper check to prevent heap overflow
On Fri, 2015-05-15 at 15:02 +0000, David Laight wrote:
> From: Jason A. Donenfeld
> > Sent: 13 May 2015 19:34
> > Since elt->length is a u8, we can make this variable a u8. Then we can
> > do proper bounds checking more easily. Without this, a potentially
> > negative value is passed to the memcpy inside oz_hcd_get_desc_cnf,
> > resulting in a remotely exploitable heap overflow with network
> > supplied data.
> ...
> > diff --git a/drivers/staging/ozwpan/ozusbsvc1.c b/drivers/staging/ozwpan/ozusbsvc1.c
> > index d434d8c..cd6c63e 100644
> > --- a/drivers/staging/ozwpan/ozusbsvc1.c
> > +++ b/drivers/staging/ozwpan/ozusbsvc1.c
> > @@ -390,8 +390,10 @@ void oz_usb_rx(struct oz_pd *pd, struct oz_elt *elt)
> > case OZ_GET_DESC_RSP: {
> > struct oz_get_desc_rsp *body =
> > (struct oz_get_desc_rsp *)usb_hdr;
> > - int data_len = elt->length -
> > + u8 data_len = elt->length -
> > sizeof(struct oz_get_desc_rsp) + 1;
> > + if (data_len > elt->length)
> > + break;
This check already seems bogus? It's really:
if (sizeof(struct oz_get_desc_rsp) - 1 < 0)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists