netdev - Re: [PATCH] vxlan: correct typo in call to unregister_netdevice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150518.165941.65628962518379011.davem@davemloft.net>
Date:	Mon, 18 May 2015 16:59:41 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	linville@...driver.com
Cc:	netdev@...r.kernel.org, nicolas.dichtel@...nd.com
Subject: Re: [PATCH] vxlan: correct typo in call to
 unregister_netdevice_queue

From: "John W. Linville" <linville@...driver.com>
Date: Mon, 18 May 2015 13:51:24 -0400

> By inspection, this appears to be a typo.  The gating comparison
> involves vxlan->dev rather than dev.  In fact, dev is the iterator in
> the preceding loop above but it is actually constant in the 2nd loop.
> 
> Use of dev seems to be a bad cut-n-paste from the prior call to
> unregister_netdevice_queue.  Change dev to vxlan->dev, since that is
> what is actually being checked.
> 
> Signed-off-by: John W. Linville <linville@...driver.com>

Indeed, your fix looks correct to me.

Applied, thanks John.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html