netdev - Re: [PATCH] vxlan: correct typo in call to unregister_netdevice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <555C41EC.6040100@6wind.com>
Date:	Wed, 20 May 2015 10:12:28 +0200
From:	Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:	David Miller <davem@...emloft.net>, linville@...driver.com
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH] vxlan: correct typo in call to unregister_netdevice_queue

Le 18/05/2015 22:59, David Miller a écrit :
> From: "John W. Linville" <linville@...driver.com>
> Date: Mon, 18 May 2015 13:51:24 -0400
>
>> By inspection, this appears to be a typo.  The gating comparison
>> involves vxlan->dev rather than dev.  In fact, dev is the iterator in
>> the preceding loop above but it is actually constant in the 2nd loop.
>>
>> Use of dev seems to be a bad cut-n-paste from the prior call to
>> unregister_netdevice_queue.  Change dev to vxlan->dev, since that is
>> what is actually being checked.
>>
>> Signed-off-by: John W. Linville <linville@...driver.com>
>
> Indeed, your fix looks correct to me.
>
> Applied, thanks John.
>
I was off the last couple of days. But I agree with that patch.
FWIW:
Fixes: f01ec1c017de ("vxlan: add x-netns support")
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html