netdev - Re: [net-next] netlink: Use random autobind rover

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150517.234407.1144377163556453362.davem@davemloft.net>
Date:	Sun, 17 May 2015 23:44:07 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	eric.dumazet@...il.com, tgraf@...g.ch, netdev@...r.kernel.org,
	ying.xue@...driver.com
Subject: Re: [net-next] netlink: Use random autobind rover

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Sun, 17 May 2015 10:45:34 +0800

> On Sat, May 16, 2015 at 05:08:19PM -0400, David Miller wrote:
>>
>> As far as I can tell, this ought to be fine as-is.
> 
> OK what about dropping the global rover altogether? Let's just
> start randomly like UDP.
> 
> ---8<---
> Currently we use a global rover to select a port ID that is unique.
> This used to work consistently when it was protected with a global
> lock.  However as we're now lockless, the global rover can exhibit
> pathological behaviour should multiple threads all stomp on it at
> the same time.
> 
> Granted this will eventually resolve itself but the process is
> suboptimal.
> 
> This patch replaces the global rover with a pseudorandom starting
> point to avoid this issue.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Yep, this is fine, applied.

Thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html