netdev - Re: [PATCH net-next 1/3] cxgb4: Add support for loopback between VI of same port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150517.234613.463972132331185537.davem@davemloft.net>
Date:	Sun, 17 May 2015 23:46:13 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	hariprasad@...lsio.com
Cc:	netdev@...r.kernel.org, leedom@...lsio.com, nirranjan@...lsio.com
Subject: Re: [PATCH net-next 1/3] cxgb4: Add support for loopback between
 VI of same port

From: Hariprasad Shenai <hariprasad@...lsio.com>
Date: Sun, 17 May 2015 16:15:21 +0530

> We now have a new cxgb4 module parameter "tx_vf" that when set
> to a non-zero value, causes cxgb4 to use the "Virtual Machine" version
> of the firmware Ethernet TX Packet Work Request (FW_ETH_TX_PKT_VM_WR)
> instead of the "normal" default non-VM Work Request (FW_ETH_TX_PKT_WR).
> This allows TX Packets sent by the cxgb4 PF Driver to be subject to the
> firmware's MPS TCAM Lookup and therefore elligable for loop back to other
> Virtual interfaces on the same port. This is useful for communicating with
> Virtual machines running the VF Driver (cxgb4vf) and also for interesting
> layered service applications. Enabling it by default lowers the
> performance, so maybe module parameter is the right way to this.
> 
> Based on original work by Casey Leedom <leedom@...lsio.com>
> 
> Signed-off-by: Hariprasad Shenai <hariprasad@...lsio.com>

Sorry, module parameters are veboten.

Especially for settings like this which are guaranteed to be
interesting for other NIC drivers, not just your's.

I'm really tired of explaining this to driver authors.  Just
don't even try to push a module parameter past me.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html