netdev - Re: Bug in tcp timestamp option ? TSecr in SYN-ACK != TSval in SYN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 May 2015 10:29:15 -0700
From:	Gopakumar Choorakkot Edakkunni <gopakumar.c.e@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org, Yuchung Cheng <ycheng@...gle.com>,
	Neal Cardwell <ncardwell@...gle.com>,
	Van Jacobson <vanj@...gle.com>
Subject: Re: Bug in tcp timestamp option ? TSecr in SYN-ACK != TSval in SYN

Thanks Eric. I will give this a spin. The issue doesnt happen all the
time, I can keep the server running with this patch for a while and
observe if the issue resurfaces or not

Rgds,
Gopa.

On Wed, May 27, 2015 at 6:45 AM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Wed, 2015-05-27 at 06:33 -0700, Eric Dumazet wrote:
>
>> The problem is in linux code itself. Please try the patch I sent ?
>> (On the client)
>
> On the server, sorry for the typo.
>
>>
>> diff --git a/net/ipv4/tcp_minisocks.c b/net/ipv4/tcp_minisocks.c
>> index df7fe3c31162e77b96f81399ef7d893485ab3d91..70db6572d241e132c28c381dfc1155b150c9557b 100644
>> --- a/net/ipv4/tcp_minisocks.c
>> +++ b/net/ipv4/tcp_minisocks.c
>> @@ -588,6 +588,9 @@ struct sock *tcp_check_req(struct sock *sk, struct sk_buff *skb,
>>       if (TCP_SKB_CB(skb)->seq == tcp_rsk(req)->rcv_isn &&
>>           flg == TCP_FLAG_SYN &&
>>           !paws_reject) {
>> +             if (tmp_opt.saw_tstamp &&
>> +                 after(tmp_opt.rcv_tsval, req->ts_recent))
>> +                     req->ts_recent = tmp_opt.rcv_tsval;
>>               /*
>>                * RFC793 draws (Incorrectly! It was fixed in RFC1122)
>>                * this case on figure 6 and figure 8, but formal
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html