netdev - Re: Bug in tcp timestamp option ? TSecr in SYN-ACK != TSval in SYN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1432734319.4060.383.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 27 May 2015 06:45:19 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Gopakumar Choorakkot Edakkunni <gopakumar.c.e@...il.com>
Cc:	netdev@...r.kernel.org, Yuchung Cheng <ycheng@...gle.com>,
	Neal Cardwell <ncardwell@...gle.com>,
	Van Jacobson <vanj@...gle.com>
Subject: Re: Bug in tcp timestamp option ? TSecr in SYN-ACK != TSval in SYN

On Wed, 2015-05-27 at 06:33 -0700, Eric Dumazet wrote:

> The problem is in linux code itself. Please try the patch I sent ?
> (On the client)

On the server, sorry for the typo.

> 
> diff --git a/net/ipv4/tcp_minisocks.c b/net/ipv4/tcp_minisocks.c
> index df7fe3c31162e77b96f81399ef7d893485ab3d91..70db6572d241e132c28c381dfc1155b150c9557b 100644
> --- a/net/ipv4/tcp_minisocks.c
> +++ b/net/ipv4/tcp_minisocks.c
> @@ -588,6 +588,9 @@ struct sock *tcp_check_req(struct sock *sk, struct sk_buff *skb,
>  	if (TCP_SKB_CB(skb)->seq == tcp_rsk(req)->rcv_isn &&
>  	    flg == TCP_FLAG_SYN &&
>  	    !paws_reject) {
> +		if (tmp_opt.saw_tstamp &&
> +		    after(tmp_opt.rcv_tsval, req->ts_recent))
> +			req->ts_recent = tmp_opt.rcv_tsval;
>  		/*
>  		 * RFC793 draws (Incorrectly! It was fixed in RFC1122)
>  		 * this case on figure 6 and figure 8, but formal


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html