netdev - Re: [PATCH net-next] vxlan: release lock after each bucket in vxlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALh4rZoiRw8ng6X3+=qyYJ1K4BtQPJM7QwMKKBvazp4EkA27_Q@mail.gmail.com>
Date:	Wed, 27 May 2015 21:09:39 +0300
From:	Sorin Dumitru <sorin@...urnze.ro>
To:	Cong Wang <cwang@...pensource.com>
Cc:	netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Sorin Dumitru <sdumitru@...acom.com>
Subject: Re: [PATCH net-next] vxlan: release lock after each bucket in vxlan_cleanup

On Wed, May 27, 2015 at 8:44 PM, Cong Wang <cwang@...pensource.com> wrote:
> On Tue, May 26, 2015 at 12:42 AM, Sorin Dumitru <sorin@...urnze.ro> wrote:
>> We're seeing some softlockups from this function when there
>> are a lot fdb entries on a vxlan device. Taking the lock for
>> each bucket instead of the whole table is enough to fix that.
>>
>
> Hmm, then the spinlock could be moved into each bucket, right?

Yes, it could, but I'm not sure if it will benefit us too much. I didn't see
too much contention on this lock while adding and removing fdb entries.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html