netdev - Re: [PATCH net-next] vxlan: release lock after each bucket in vxlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150527.143130.381509373001563210.davem@davemloft.net>
Date:	Wed, 27 May 2015 14:31:30 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	cwang@...pensource.com
Cc:	sorin@...urnze.ro, netdev@...r.kernel.org, sdumitru@...acom.com
Subject: Re: [PATCH net-next] vxlan: release lock after each bucket in
 vxlan_cleanup

From: Cong Wang <cwang@...pensource.com>
Date: Wed, 27 May 2015 10:44:26 -0700

> On Tue, May 26, 2015 at 12:42 AM, Sorin Dumitru <sorin@...urnze.ro> wrote:
>> We're seeing some softlockups from this function when there
>> are a lot fdb entries on a vxlan device. Taking the lock for
>> each bucket instead of the whole table is enough to fix that.
>>
> 
> Hmm, then the spinlock could be moved into each bucket, right?

Just because this one big one-time cleanup operation holds the lock
for a long time, doesn't justify making it more granular.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html