netdev - Re: [PATCH v4] bnx2x: Alloc 4k fragment for each rx ring buffer element

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zj4osui4.fsf@sycorax.br.ibm.com>
Date:	Thu, 28 May 2015 10:26:43 -0300
From:	Gabriel Krisman Bertazi <krisman@...ux.vnet.ibm.com>
To:	Yuval Mintz <Yuval.Mintz@...gic.com>
Cc:	Michal Schmidt <mschmidt@...hat.com>,
	David Miller <davem@...emloft.net>,
	"LinoSanfilippo\@gmx.de" <LinoSanfilippo@....de>,
	Ariel Elior <Ariel.Elior@...gic.com>,
	netdev <netdev@...r.kernel.org>,
	"cascardo\@cascardo.eti.br" <cascardo@...cardo.eti.br>,
	"brking\@linux.vnet.ibm.com" <brking@...ux.vnet.ibm.com>
Subject: Re: [PATCH v4] bnx2x: Alloc 4k fragment for each rx ring buffer element

Yuval Mintz <Yuval.Mintz@...gic.com> writes:

> Actually, this upsets me greatly. We didn't see it on a system with 4KB
> pages, but this means you've actually tried to 'sell' us a fastpath fix that
> was never tested on machines for which it was meant as an improvement.

The iteration that inserted this bug was such a quick fix that I didn`t
bother rerunning it.  It just modified the type variable.  Take my word
it was a one time honest mistake.

The last iteration, as well as all of the previous ones were tested on
Power servers with bnx2x adapters.  The tests included stressing the
device and several iterations of hotplugging the adapter, helping us to
verify correctness of the rx queue operation as well as verifying that DMA
mapping/unmapping were correct.

-- 
Gabriel Krisman Bertazi

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html