netdev - Re: [PATCH] bnx2x: Alloc 4k fragment for each rx ring buffer element

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150601.155701.499463944154053931.davem@davemloft.net>
Date:	Mon, 01 Jun 2015 15:57:01 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	krisman@...ux.vnet.ibm.com
Cc:	mschmidt@...hat.com, Yuval.Mintz@...gic.com, LinoSanfilippo@....de,
	Ariel.Elior@...gic.com, netdev@...r.kernel.org,
	cascardo@...cardo.eti.br, brking@...ux.vnet.ibm.com
Subject: Re: [PATCH] bnx2x: Alloc 4k fragment for each rx ring buffer
 element

From: Gabriel Krisman Bertazi <krisman@...ux.vnet.ibm.com>
Date: Wed, 27 May 2015 13:51:43 -0300

> Subject: [PATCH] bnx2x: Alloc 4k fragment for each rx ring buffer element
> 
> The driver allocates one page for each buffer on the rx ring, which is
> too much on architectures like ppc64 and can cause unexpected allocation
> failures when the system is under stress.  Now, we keep a memory pool
> per queue, and if the architecture's PAGE_SIZE is greater than 4k, we
> fragment pages and assign each 4k segment to a ring element, which
> reduces the overall memory consumption on such architectures.  This
> helps avoiding errors like the example below:
> 
> [bnx2x_alloc_rx_sge:435(eth1)]Can't alloc sge
> [c00000037ffeb900] [d000000075eddeb4] .bnx2x_alloc_rx_sge+0x44/0x200 [bnx2x]
> [c00000037ffeb9b0] [d000000075ee0b34] .bnx2x_fill_frag_skb+0x1ac/0x460 [bnx2x]
> [c00000037ffebac0] [d000000075ee11f0] .bnx2x_tpa_stop+0x160/0x2e8 [bnx2x]
> [c00000037ffebb90] [d000000075ee1560] .bnx2x_rx_int+0x1e8/0xc30 [bnx2x]
> [c00000037ffebcd0] [d000000075ee2084] .bnx2x_poll+0xdc/0x3d8 [bnx2x] (unreliable)
> 
> Signed-off-by: Gabriel Krisman Bertazi <krisman@...ux.vnet.ibm.com>
> Acked-by: Yuval Mintz <Yuval.Mintz@...gic.com>
> Reviewed-by: Lino Sanfilippo <LinoSanfilippo@....de>

I think I've waited long enough on this, applied to net-next, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html