netdev - Re: [PATCH v4 net-next 05/11] net: Add full IPv6 addresses to flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1432849496.7456.34.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Thu, 28 May 2015 14:44:56 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Tom Herbert <tom@...bertland.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH v4 net-next 05/11] net: Add full IPv6 addresses to
 flow_keys

On Thu, 2015-05-28 at 11:19 -0700, Tom Herbert wrote:

> @@ -566,11 +640,15 @@ static const struct flow_dissector_key flow_keys_dissector_keys[] = {
>  	},
>  	{
>  		.key_id = FLOW_DISSECTOR_KEY_IPV4_ADDRS,
> -		.offset = offsetof(struct flow_keys, addrs),
> +		.offset = offsetof(struct flow_keys, addrs.v4addrs),
> +	},
> +	{
> +		.key_id = FLOW_DISSECTOR_KEY_IPV6_ADDRS,
> +		.offset = offsetof(struct flow_keys, addrs.v6addrs),
>  	},
>  	{
>  		.key_id = FLOW_DISSECTOR_KEY_IPV6_HASH_ADDRS,
> -		.offset = offsetof(struct flow_keys, addrs),
> +		.offset = offsetof(struct flow_keys, addrs.v4addrs),

Shouldn't it be offsetof(struct flow_keys, addrs.v6addrs), ?



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html