netdev - Re: [PATCH v4 net-next 05/11] net: Add full IPv6 addresses to flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALx6S36WsA_GgEsWo96BPtJm95knCnusNOw_vsUOhQZnC5BxQw@mail.gmail.com>
Date:	Thu, 28 May 2015 15:38:14 -0700
From:	Tom Herbert <tom@...bertland.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH v4 net-next 05/11] net: Add full IPv6 addresses to flow_keys

On Thu, May 28, 2015 at 2:44 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Thu, 2015-05-28 at 11:19 -0700, Tom Herbert wrote:
>
>> @@ -566,11 +640,15 @@ static const struct flow_dissector_key flow_keys_dissector_keys[] = {
>>       },
>>       {
>>               .key_id = FLOW_DISSECTOR_KEY_IPV4_ADDRS,
>> -             .offset = offsetof(struct flow_keys, addrs),
>> +             .offset = offsetof(struct flow_keys, addrs.v4addrs),
>> +     },
>> +     {
>> +             .key_id = FLOW_DISSECTOR_KEY_IPV6_ADDRS,
>> +             .offset = offsetof(struct flow_keys, addrs.v6addrs),
>>       },
>>       {
>>               .key_id = FLOW_DISSECTOR_KEY_IPV6_HASH_ADDRS,
>> -             .offset = offsetof(struct flow_keys, addrs),
>> +             .offset = offsetof(struct flow_keys, addrs.v4addrs),
>
> Shouldn't it be offsetof(struct flow_keys, addrs.v6addrs), ?
>
This is to hash 128 bit IP addresses into 32 bit values which fit in
the v4addrs area. This completely goes away in 07 patch in this set.

>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html