netdev - Re: Looking for a lost patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150528055150.GG27342@secunet.com>
Date:	Thu, 28 May 2015 07:51:52 +0200
From:	Steffen Klassert <steffen.klassert@...unet.com>
To:	David Miller <davem@...emloft.net>
CC:	<alexander.h.duyck@...hat.com>, <alexander.duyck@...il.com>,
	<netdev@...r.kernel.org>
Subject: Re: Looking for a lost patch

On Wed, May 27, 2015 at 11:46:03AM -0400, David Miller wrote:
> From: Steffen Klassert <steffen.klassert@...unet.com>
> Date: Wed, 27 May 2015 10:35:16 +0200
> 
> > We currently check if a socket is attached to a skb and do socket
> > error notification in this case, otherwise we do PMTU discovery if
> > the packet is too big. Looks like this socket check is not sufficient
> > if the packet is already transmitted through a tunnel device.
> > 
> > I wonder if we have something to know that a packet was already
> > transmitted through a tunnel device. We could switch from socket
> > notification to PMTU discovery in this case.
> 
> Generally speaking, we should not be orphaning the socket as it
> traverses through tunnels.
> 
> In fact we have taken great pains to avoid doing this.

Yes, I'm aware of this. I don't want to orphan the socket,
all I wanted to do is to change the way we notify about MTU
changes. I.e. use icmpv6_send() instead of xfrm_local_error()
if the packet traversed a tunnel, that's why I wondered whether
we can know this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html