netdev - Re: [Xen-devel] xen-netfront sets partial checksum at wrong offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150529103916.GY30474@zion.uk.xensource.com>
Date:	Fri, 29 May 2015 11:39:16 +0100
From:	Wei Liu <wei.liu2@...rix.com>
To:	Jan Beulich <JBeulich@...e.com>
CC:	Venkat Venkatsubra <venkat.x.venkatsubra@...cle.com>,
	<david.vrabel@...rix.com>, <ian.campbell@...rix.com>,
	<wei.liu2@...rix.com>, <xen-devel@...ts.xenproject.org>,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>,
	Konrad Wilk <konrad.wilk@...cle.com>, <netdev@...r.kernel.org>
Subject: Re: [Xen-devel] xen-netfront sets partial checksum at wrong offset

On Fri, May 29, 2015 at 11:34:07AM +0100, Jan Beulich wrote:
> >>> On 11.05.15 at 19:25, <venkat.x.venkatsubra@...cle.com> wrote:
> >>  
> >> Please CC the maintainers of the driver. You can get that from
> >> 'scripts/get_maintainer.pl'
> >> 
> >> I've done that for you.
> > 
> > Thanks, Konrad.
> > 
> > I am copying Wei too who had fixed the below problem earlier.
> > It fixed the incorrect ip_hdr(). tcp_hdr() still needs to fixed.
> > 
> > commit d554f73df6bc35ac8f6a65e5560bf1d31dfebed9
> > Author: Wei Liu <wei.liu2@...rix.com>
> > Date:   Wed Feb 19 18:48:34 2014 +0000
> > 
> >     xen-netfront: reset skb network header before checksum
> 
> So no response at all so far from the maintainers made me look into
> this: I first thought what we need would be calls to
> skb_probe_transport_header() in skb_checksum_setup_ip() after
> each of the skb_maybe_pull_tail() functions. But
> skb_partial_csum_set() already calls skb_set_transport_header(),
> so I now think things ought to be fine without any change. Can
> you clarify what you think is missing? Or is this an issue in just the
> old (3.8.x) kernel you're using?
> 

I think this is the follow-up thread <20150512013424.GA7960@...cle.com>

And the conclusion is 3.8 is too old so the fix is not there.

> (In either case netback's xenvif_tx_submit() calling
> skb_probe_transport_header() would seem pointless, as
> skb_checksum_setup() - with or without a fix - ought to be taking
> care of this anyway.)
> 

Patches welcome. :-)

Wei.

> Jan
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html