netdev - Re: [PATCH 0/2] Fix couple of issues with 'ethtool' get/set API's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 31 May 2015 20:59:39 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Arun Parameswaran <aparames@...adcom.com>
Cc:	Ben Hutchings <bwh@...nel.org>, netdev@...r.kernel.org,
	jdzheng@...adcom.com
Subject: Re: [PATCH 0/2] Fix couple of issues with 'ethtool' get/set API's

On Fri, 2015-05-22 at 15:43 -0700, Arun Parameswaran wrote:
> Hi,
> The patch fixes 2 issues with 'ethtool' getting/setting parametres in
> the do_gset() do_sset() API's.
> 
> I have pushed a patch to the Kernel to fix an issue in the handling of
> the 'ethtool' commands which got accepted.
> This Kernel patch was based on Linux v4.1-rc4 and is available in:
> https://github.com/Broadcom/cygnus-linux/tree/net-core-ethtool-fix-v1
> 
> The Kernel was always clearing the command from the 'ethtool' resulting
> in all operations to deal with PHY0. This prevents querying/setting
> PHY 1's settings.
[...]

Each net device can be associated with a single PHY at a time, and the
ETHTOOL_GSET implementation should fill in the PHY address in the
ethtool_cmd::phy_address field.  Where there are multiple PHYs that can
be connected to the net device's MAC, an ETHTOOL_SSET operation can be
used to change that PHY address.

The ethtool API is not meant for controlling other PHYs that aren't
connected to the MAC; if you want to do that then create more net
devices for them or use the MDIO ioctls.

Ben.

-- 
Ben Hutchings
Reality is just a crutch for people who can't handle science fiction.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)