netdev - Re: [PATCH net V1] ethtool: Support for configurable RSS hash function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1433102761.6319.111.camel@decadent.org.uk>
Date:	Sun, 31 May 2015 21:06:01 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Amir Vadai <amirv@...lanox.com>
Cc:	netdev <netdev@...r.kernel.org>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Tal Alon <talal@...lanox.com>, Eyal Perry <eyalpe@...lanox.com>
Subject: Re: [PATCH net V1] ethtool: Support for configurable RSS hash
 function

On Tue, 2015-05-05 at 18:48 +0300, Amir Vadai wrote:
> On Mon, Apr 27, 2015 at 2:22 PM, Amir Vadai <amirv@...lanox.com> wrote:
> > From: Eyal Perry <eyalpe@...lanox.com>
> >
> > This ethtool patch adds support to set and get the current RSS hash
> > function for the device through through the new hfunc field in the
> > ethtool_rxfh struct. Kernel supported hash function names are queried
> > with ETHTOOL_GSTRINGS (value 0 is reserved and skipped).
> >
> > Although currently no device supports a combination of hash
> > functions/attributes, this ethtool implementation will support it. Both in the
> > set and in the get.
> > The device driver declares the functions and/or attributes that it supports,
> > and ethtool will show it correctly and enable the user to set those
> > combinations.
> > If a combination is not supported - the device driver will fail the operation
> > and ethtool will print an error message.
> >
> > Signed-off-by: Eyal Perry <eyalpe@...lanox.com>
> > Signed-off-by: Amir Vadai <amirv@...lanox.com>
> > ---
> > Changes from V1:
> > - Fixed some English mistakes
> > - Fixed the complicated way to write '= req_hfunc;'...
> > - Better support in combination of hash functions/attributes
> 
> Ben Hi,
> 
> Could you take a look at this patch?

Didn't we agree that only one hash function should be selected at once?
Can you send a new version that implements that?

Ben.

-- 
Ben Hutchings
Reality is just a crutch for people who can't handle science fiction.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)