netdev - Re: [PATCH net V1] ethtool: Support for configurable RSS hash function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPcc5PgiKoT4=9u3J7Dcmt_Fy7Wc+wPk5p3=qeK2tQRpCzVQbg@mail.gmail.com>
Date:	Tue, 2 Jun 2015 09:31:32 +0300
From:	Amir Vadai <amirv@...lanox.com>
To:	Ben Hutchings <ben@...adent.org.uk>,
	Amir Vadai <amirv@...lanox.com>
CC:	netdev <netdev@...r.kernel.org>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Tal Alon <talal@...lanox.com>, Eyal Perry <eyalpe@...lanox.com>
Subject: Re: [PATCH net V1] ethtool: Support for configurable RSS hash function

On Sun, May 31, 2015 at 11:09 PM Ben Hutchings <ben@...adent.org.uk> wrote:
>
> On Tue, 2015-05-05 at 18:48 +0300, Amir Vadai wrote:
> > On Mon, Apr 27, 2015 at 2:22 PM, Amir Vadai <amirv@...lanox.com> wrote:
> > > From: Eyal Perry <eyalpe@...lanox.com>
> > >
> > > This ethtool patch adds support to set and get the current RSS hash
> > > function for the device through through the new hfunc field in the
> > > ethtool_rxfh struct. Kernel supported hash function names are queried
> > > with ETHTOOL_GSTRINGS (value 0 is reserved and skipped).
> > >
> > > Although currently no device supports a combination of hash
> > > functions/attributes, this ethtool implementation will support it. Both in the
> > > set and in the get.
> > > The device driver declares the functions and/or attributes that it supports,
> > > and ethtool will show it correctly and enable the user to set those
> > > combinations.
> > > If a combination is not supported - the device driver will fail the operation
> > > and ethtool will print an error message.
> > >
> > > Signed-off-by: Eyal Perry <eyalpe@...lanox.com>
> > > Signed-off-by: Amir Vadai <amirv@...lanox.com>
> > > ---
> > > Changes from V1:
> > > - Fixed some English mistakes
> > > - Fixed the complicated way to write '= req_hfunc;'...
> > > - Better support in combination of hash functions/attributes
> >
> > Ben Hi,
> >
> > Could you take a look at this patch?
>
> Didn't we agree that only one hash function should be selected at once?
> Can you send a new version that implements that?
Yeh, and actually I did send a V1 according to that approach, but Dave
Miller has suggested [1] that we might add control attributes in
combination to the hash function.

[1] - http://permalink.gmane.org/gmane.linux.network/360812

Amir

>
> Ben.
>
> --
> Ben Hutchings
> Reality is just a crutch for people who can't handle science fiction.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html