netdev - Re: [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <556D4E4F.5090609@huawei.com>
Date:	Tue, 2 Jun 2015 14:33:51 +0800
From:	Junling Zheng <zhengjunling@...wei.com>
To:	David Miller <davem@...emloft.net>
CC:	<gregkh@...uxfoundation.org>, <lizefan@...wei.com>,
	<viro@...iv.linux.org.uk>, <xuhanbing@...wei.com>,
	<stable@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg
 and sendmsg

On 2015/6/2 13:23, David Miller wrote:
> From: Junling Zheng <zhengjunling@...wei.com>
> Date: Tue, 2 Jun 2015 12:05:32 +0800
> 
>> So, the problem commit is 281c9c36 (net: compat: Update
>> get_compat_msghdr() to match copy_msghdr_from_user() behaviour),
>> which fixes db31c55a6fb2 and brings the get_compat_msghdr() in line
>> with copy_msghdr_from_user().
> 
> Upstream this got fixed by:
> 
> 08adb7dabd4874cc5666b4490653b26534702ce0
> 
> So the part that makes us not unconditionally return -EFAULT needs
> to be backported, and that's probably equivalent to the patch
> your proposed which therefore should be applied.
> 
> .
> 
Yes, we indeed missed some changes of 08adb7d, and these changes could
make commit 281c9c36 appropriate for stable version.
In addition, I think other stable version also needs this fix.

Cheers,

Junling

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html