netdev - Re: [PATCH v2] xen: netback: fix printf format string warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150601.120343.1122621914202084967.davem@davemloft.net>
Date:	Mon, 01 Jun 2015 12:03:43 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ian.campbell@...rix.com
Cc:	xen-devel@...ts.xen.org, netdev@...r.kernel.org,
	wei.liu2@...rix.com
Subject: Re: [PATCH v2] xen: netback: fix printf format string warning

From: Ian Campbell <ian.campbell@...rix.com>
Date: Mon, 1 Jun 2015 11:30:04 +0100

> drivers/net/xen-netback/netback.c: In function ‘xenvif_tx_build_gops’:
> drivers/net/xen-netback/netback.c:1253:8: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘int’ [-Wformat=]
>         (txreq.offset&~PAGE_MASK) + txreq.size);
>         ^
> 
> PAGE_MASK's type can vary by arch, so a cast is needed.
> 
> Signed-off-by: Ian Campbell <ian.campbell@...rix.com>
> ----
> v2: Cast to unsigned long, since PAGE_MASK can vary by arch.

Applied.