netdev - Re: [PATCH net] bnx2x: Move statistics implementation into semaphores

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150601.120442.564203066952951915.davem@davemloft.net>
Date:	Mon, 01 Jun 2015 12:04:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	Yuval.Mintz@...gic.com
Cc:	netdev@...r.kernel.org, nikola.ciprich@...uxbox.cz,
	Ariel.Elior@...gic.com
Subject: Re: [PATCH net] bnx2x: Move statistics implementation into
 semaphores

From: Yuval Mintz <Yuval.Mintz@...gic.com>
Date: Mon, 1 Jun 2015 15:08:18 +0300

> Commit dff173de84958 ("bnx2x: Fix statistics locking scheme") changed the
> bnx2x locking around statistics state into using a mutex - but the lock
> is being accessed via a timer which is forbidden.
> 
> [If compiled with CONFIG_DEBUG_MUTEXES, logs show a warning about
> accessing the mutex in interrupt context]
> 
> This moves the implementation into using a semaphore [with size '1']
> instead.
> 
> Signed-off-by: Yuval Mintz <Yuval.Mintz@...gic.com>
> Signed-off-by: Ariel Elior <Ariel.Elior@...gic.com>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html