netdev - Re: [cdc_ncm] guidance and help refactoring cdc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1433144906.1557.2.camel@suse.com>
Date:	Mon, 01 Jun 2015 09:48:26 +0200
From:	Oliver Neukum <oneukum@...e.com>
To:	Enrico Mioso <mrkiko.rs@...il.com>
Cc:	Greg KH <greg@...ah.com>, linux-usb@...r.kernel.org,
	netdev@...r.kernel.org, youtux@...il.com
Subject: Re: [cdc_ncm] guidance and help refactoring cdc_ncm

On Mon, 2015-06-01 at 08:53 +0200, Enrico Mioso wrote:

> A 32-bit version of the driver (talking 32-bit NCM) is here:
> http://www.gstorm.eu/cdc_ncm.c
> I modified the original driver with the help of a very talented friend.
> It works: but there seem to be no real reasons to implement this properly. We 
> did this in a consistent effort to understand what was wrong, and here it is.

Well, you are really talking about two different things here.
Do we ever fail because we only do 16 bit as opposed to 32 bit?
Your 32 bit driver looks good, but it raises the question of what to do
if this test:

        if (le16_to_cpu(ctx->ncm_parm.bmNtbFormatsSupported) &
                                                USB_CDC_NCM_NTB32_SUPPORTED) {

fails. Otherwise it looks ready for merging.

	Regards
		Oliver



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html