netdev - Re: 2.6.32.66 tcp regression OOPs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150601074922.GA28740@1wt.eu>
Date:	Mon, 1 Jun 2015 09:49:22 +0200
From:	Willy Tarreau <w@....eu>
To:	Frans Klaver <fransklaver@...il.com>
Cc:	starlight.2015q2@...nacle.cx,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>
Subject: Re: 2.6.32.66 tcp regression OOPs

Hi,

On Mon, Jun 01, 2015 at 09:00:21AM +0200, Frans Klaver wrote:
> [cc: Willy Tarreau]
> 
> On Mon, Jun 1, 2015 at 3:26 AM,  <starlight.2015q2@...nacle.cx> wrote:
> > Hello,
> >
> > Apoligies if I have submitted to the wrong lists.
> >
> > Encountered a regression in
> > 2.6.32.66 relative to 2.6.32.65.
> >
> > Crash eight minutes after boot.
> >
> > Will responded with additional details
> > if the OOPS is not sufficent.
> >
> > Best Regards
> >
> 
> Did you bisect it?

Eric Dumazet notified me that of something possibly similar due to
a mistake I made when backporting a fix by hand.

Please apply the following patch to see if it fixes the problem :

diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c                      
index 5339f066234b..d1e2895bb63c 100644                                         
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
@@ -2136,7 +2136,7 @@ void tcp_send_fin(struct sock *sk)
	 */
	if (tskb && (tcp_send_head(sk) || tcp_memory_pressure)) {
 coalesce:
-		TCP_SKB_CB(skb)->flags |= TCPCB_FLAG_FIN;
+		TCP_SKB_CB(tskb)->flags |= TCPCB_FLAG_FIN;
		TCP_SKB_CB(tskb)->end_seq++;
		tp->write_seq++;
	if (!tcp_send_head(sk)) {

Thanks,
Willy

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html