netdev - Re: [PATCH net-next 1/2] bpf: make programs see skb->data == L2 for ingress and egress

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150604.011153.2117612661989458005.davem@davemloft.net>
Date:	Thu, 04 Jun 2015 01:11:53 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ast@...mgrid.com
Cc:	edumazet@...gle.com, jhs@...atatu.com, daniel@...earbox.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] bpf: make programs see skb->data == L2
 for ingress and egress

From: Alexei Starovoitov <ast@...mgrid.com>
Date: Wed,  3 Jun 2015 22:07:10 -0700

> +	u32 at_ingress = G_TC_AT(skb->tc_verd) & AT_INGRESS;

Please use a 'bool' for this.

> @@ -64,6 +64,7 @@ static int cls_bpf_classify(struct sk_buff *skb, const struct tcf_proto *tp,
>  {
>  	struct cls_bpf_head *head = rcu_dereference_bh(tp->root);
>  	struct cls_bpf_prog *prog;
> +	u32 at_ingress = G_TC_AT(skb->tc_verd) & AT_INGRESS;
>  	int ret = -1;
>  
>  	if (unlikely(!skb_mac_header_was_set(skb)))

Likewise.

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html