netdev - Re: [PATCH net-next] openvswitch: include actions with upcall if allocation allows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150604.011353.1589451290206511811.davem@davemloft.net>
Date:	Thu, 04 Jun 2015 01:13:53 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	neil.mckee@...on.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] openvswitch: include actions with upcall if
 allocation allows

From: Neil McKee <neil.mckee@...on.com>
Date: Wed,  3 Jun 2015 15:31:07 -0700

> Back out the OVS_USERSPACE_ATTR_ACTIONS attribute that was
> gating the inclusion of datapath actions in the upcall.
> Instead include the actions every time, provided there is no
> problem with the atomic allocation.  If the atomic allocation
> fails then try it again with the actions omitted.
> 
> Signed-off-by: Neil McKee <neil.mckee@...on.com>

Conditionally providing the attributes to the user is completely
terrible semantics.

If the user really needs these, then he won't be happy to get the
upcall without them, he'd rather the upcall fail completely
instead.

I'm not applying this patch, this change was not well thought out
at all.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html