netdev - Re: [PATCH net-next] net/mlx4_core: Fix build failure introduced by the EQ pool changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150603.193615.834853895798751401.davem@davemloft.net>
Date:	Wed, 03 Jun 2015 19:36:15 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ogerlitz@...lanox.com
Cc:	netdev@...r.kernel.org, mpe@...erman.id.au, amirv@...lanox.com,
	matanb@...lanox.com
Subject: Re: [PATCH net-next] net/mlx4_core: Fix build failure introduced
 by the EQ pool changes

From: Or Gerlitz <ogerlitz@...lanox.com>
Date: Tue,  2 Jun 2015 10:29:48 +0300

> When CONFIG_RFS_ACCEL or SMP aren't set, we fail to build, fix it.
> 
> Also, avoid build warning as of unused function on that setup.
> 
> Fixes: c66fa19c405a ('net/mlx4: Add EQ pool')
> Reported-by: Michael Ellerman <mpe@...erman.id.au>
> Signed-off-by: Matan Barak <matanb@...lanox.com>
> Signed-off-by: Or Gerlitz <ogerlitz@...lanox.com>

Applied, but this is really silly.

The whole reason there are backup non-SMP inline versions of
irq_set_affinity_hint() is so that drivers don't have to crap
up their drivers with ifdef'ery like this.

Just make all of this code unconditional and ignore the error,
there isn't anything you can really do if the error happens
anyways and this allows you to just silently use the non-SMP
variant which unconditionally returns -EINVAL.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html