netdev - Re: [PATCH] ipv4: inet_bind: check the addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150603.193823.2127048807981229902.davem@davemloft.net>
Date:	Wed, 03 Jun 2015 19:38:23 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	kda@...ux-powerpc.org
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ipv4: inet_bind: check the addr_len first

From: Denis Kirjanov <kda@...ux-powerpc.org>
Date: Tue,  2 Jun 2015 12:08:00 +0300

> Perform the address length check first, before calling
> the the proto specific bind() function
> 
> Signed-off-by: Denis Kirjanov <kda@...ux-powerpc.org>

This doesn't fix any actual bug, doesn't improve the code in
preparation for another change that actually benefits from
this adjustment, and so this is really an unwanted change.

This change and it's commit log message look totally arbitrary
and opaque, even to people who have been working with this
code and it's interfaces for decades.  That should tell you
something.

You have to let us know exactly why you are making a change, and what
real _actual_ bug it fixes, when you want us to consider your changes
seriously.

I'm not applying this, sorry.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html