netdev - Re: [PATCH v5 1/2] Renesas Ethernet AVB driver proper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55761A08.1050503@cogentembedded.com>
Date:	Tue, 09 Jun 2015 01:41:12 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	David Miller <davem@...emloft.net>
CC:	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, devicetree@...r.kernel.org,
	galak@...eaurora.org, netdev@...r.kernel.org,
	richardcochran@...il.com, linux-sh@...r.kernel.org,
	mitsuhiro.kimura.kc@...esas.com
Subject: Re: [PATCH v5 1/2] Renesas Ethernet AVB driver proper

On 06/09/2015 01:19 AM, David Miller wrote:

>>> Furthermore, you should pass the NAPI context into ravb_rx() and use

>>     I guess I should have one NAPI context per RX queue?

> Yes.

    Thanks, done.

>>> it so that you can invoke napi_gro_receive() on all of the packets and
>>> therefore support GRO.

>>     Hmm, I don't think I have a hardware support for generic RX offload...
>> I'm still unsure what it is anyway -- is it used for IP packet
>> defragmentation?

> It's completely implemented in software, you don't need to do anything
> other than properly invoke napi_gro_receive().

    Not even set NETIF_F_GRO?

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html