netdev - Re: [PATCH net-next] switchdev: fix handling for drivers not supporting IPv4 fib add/del ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150610.235649.1747681763810479422.davem@davemloft.net>
Date:	Wed, 10 Jun 2015 23:56:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sfeldma@...il.com
Cc:	netdev@...r.kernel.org, jiri@...nulli.us, f.fainelli@...il.com,
	andrew@...n.ch
Subject: Re: [PATCH net-next] switchdev: fix handling for drivers not
 supporting IPv4 fib add/del ops

From: sfeldma@...il.com
Date: Wed, 10 Jun 2015 17:04:49 -0700

> From: Scott Feldman <sfeldma@...il.com>
> 
> If CONFIG_NET_SWITCHDEV is enabled, but port driver does not implement
> support for IPv4 FIB add/del ops, don't fail route add/del offload
> operations.  Route adds will not be marked as OFFLOAD.  Routes will be
> installed in the kernel FIB, as usual.
> 
> This was report/fixed by Florian when testing DSA driver with net-next on
> devices with L2 offload support but no L3 offload support. What he reported
> was an initial route installed from DHCP client would fail (route not
> installed to kernel FIB).  This was triggering the setting of
> ipv4.fib_offload_disabled, which would disable route offloading after the
> first failure.  So subsequent attempts to install the route would succeed.
> 
> There is follow-on work/discussion to address the handling of route install
> failures, but for now, let's differentiate between no support and failed
> support.
> 
> Reported-by: Florian Fainelli <f.fainelli@...il.com>
> Signed-off-by: Scott Feldman <sfeldma@...il.com>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html