netdev - Re: [PATCH net-next] switchdev: fix BUG when port driver doesn't support set attr op

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 11 Jun 2015 00:06:13 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sfeldma@...il.com
Cc:	netdev@...r.kernel.org, jiri@...nulli.us, bblanco@...mgrid.com
Subject: Re: [PATCH net-next] switchdev: fix BUG when port driver doesn't
 support set attr op

From: sfeldma@...il.com
Date: Wed, 10 Jun 2015 13:56:02 -0700

> From: Scott Feldman <sfeldma@...il.com>
> 
> Fix a BUG() where CONFIG_NET_SWITCHDEV is set but the driver for a bridged
> port does not support switchdec_port_attr_set op.  Don't BUG() if
> -EOPNOTSUPP is returned.
> 
> Signed-off-by: Scott Feldman <sfeldma@...il.com>
> Reported-by: Brenden Blanco <bblanco@...mgrid.com>
> ---
>  net/switchdev/switchdev.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c
> index e008057..99bced4 100644
> --- a/net/switchdev/switchdev.c
> +++ b/net/switchdev/switchdev.c
> @@ -103,7 +103,7 @@ static void switchdev_port_attr_set_work(struct work_struct *work)
>  
>  	rtnl_lock();
>  	err = switchdev_port_attr_set(asw->dev, &asw->attr);
> -	BUG_ON(err);
> +	BUG_ON(err && err != -EOPNOTSUPP);
>  	rtnl_unlock();
>  
>  	dev_put(asw->dev);

I agree with other feedback, in that this function can return other "normal"
errors like -ENOMEM and that's not absolutely not BUG_ON() material.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html