netdev - Re: [net-next 09/17] fm10k: trivial fixup message style to include a colon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Jun 2015 20:33:42 +0000
From:	"Keller, Jacob E" <jacob.e.keller@...el.com>
To:	"sergei.shtylyov@...entembedded.com" 
	<sergei.shtylyov@...entembedded.com>
CC:	"nhorman@...hat.com" <nhorman@...hat.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	"jogreene@...hat.com" <jogreene@...hat.com>
Subject: Re: [net-next 09/17] fm10k: trivial fixup message style to include
 a colon

On Tue, 2015-06-16 at 17:16 +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 6/16/2015 4:47 PM, Jeff Kirsher wrote:
> 
> > From: Jacob Keller <jacob.e.keller@...el.com>
> 
> > Fix up error message style to include a colon.
> 
> > Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> > Tested-by: Krishneil Singh <Krishneil.k.singh@...el.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> > ---
> >   drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> > diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c 
> > b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
> > index 445014a..5269b16 100644
> > --- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
> > +++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
> > @@ -1773,7 +1773,7 @@ static int fm10k_probe(struct pci_dev *pdev,
> >                                        fm10k_driver_name);
> >     if (err) {
> >             dev_err(&pdev->dev,
> > -                   "pci_request_selected_regions failed 
> > 0x%x\n", err);
> > +                   "pci_request_selected_regions failed: 
> > 0x%x\n", err);
> 
>     I don't think printing error in hexadecimal makes much sense, so 
> you might 
> as well fix that format to "%d"...
> 
> WBR, Sergei
> 

Sure thing.

Regards,
Jake