netdev - Re: [net-next 07/17] fm10k: use an unsigned int for i in ethtool_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1434487076.12272.3.camel@intel.com>
Date:	Tue, 16 Jun 2015 20:37:56 +0000
From:	"Keller, Jacob E" <jacob.e.keller@...el.com>
To:	"sergei.shtylyov@...entembedded.com" 
	<sergei.shtylyov@...entembedded.com>
CC:	"nhorman@...hat.com" <nhorman@...hat.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	"jogreene@...hat.com" <jogreene@...hat.com>
Subject: Re: [net-next 07/17] fm10k: use an unsigned int for i in
 ethtool_get_strings

On Tue, 2015-06-16 at 13:33 -0700, Jacob E Keller wrote:
> On Tue, 2015-06-16 at 17:19 +0300, Sergei Shtylyov wrote:
> > On 6/16/2015 4:47 PM, Jeff Kirsher wrote:
> > 
> > > From: Jacob Keller <jacob.e.keller@...el.com>
> > 
> > > The value will never be negative, and we use the %i print format, 
> > > 
> > > use
> > 
> >     "%i" is the same as "%d", AFAIR. You need "%u" for the unsigned 
> > 
> > variables.
> > 
> > > unsigned int for the loop counter. Issue found using cppcheck.
> > 
> > > Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> > > Tested-by: Krishneil Singh <Krishneil.k.singh@...el.com>
> > > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> > 
> > WBR, Sergei
> > 
> 
> Oops, you are right.
> 
> Regards,
> Jake

The actual code does use %u, but I made a typo in the description. I am
sending an rc2.

Regards,
Jake