netdev - Re: [PATCH RFC net] neigh: do not modify unlinked entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.11.1506191115450.4285@ja.home.ssi.bg>
Date:	Fri, 19 Jun 2015 11:24:24 +0300 (EEST)
From:	Julian Anastasov <ja@....bg>
To:	YOSHIFUJI Hideaki/吉藤英明 
	<hideaki.yoshifuji@...aclelinux.com>
cc:	netdev@...r.kernel.org, Eric Dumazet <eric.dumazet@...il.com>,
	Ying Xue <ying.xue@...driver.com>, alexei@...estorage.com,
	joern@...estorage.com
Subject: Re: [PATCH RFC net] neigh: do not modify unlinked entries


	Hello,

On Fri, 19 Jun 2015, YOSHIFUJI Hideaki/吉藤英明 wrote:

> Should we always drop the packet here since it is
> already dead, shouldn't we?

	It can be a NETDEV_CHANGEADDR event, eth_header()
will build valid header. It can be some race condition
with neigh_forced_gc and neigh_periodic_work where we can
not fallback to neigh_create. It is not our job to
drop packets, so I preferred to avoid it...

Regards

--
Julian Anastasov <ja@....bg>