netdev - Re: [PATCH net-next RFC v2 3/3] mpls: support for ip tunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55857BC1.6010704@cumulusnetworks.com>
Date:	Sat, 20 Jun 2015 07:42:09 -0700
From:	roopa <roopa@...ulusnetworks.com>
To:	Robert Shearman <rshearma@...cade.com>
CC:	ebiederm@...ssion.com, tgraf@...g.ch, davem@...emloft.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next RFC v2 3/3] mpls: support for ip tunnels

On 6/19/15, 9:06 AM, Robert Shearman wrote:
>> +
>> +    /* Push the new labels */
>> +    hdr = mpls_hdr(skb);
>> +    bos = true;
>> +    for (i = tun_encap_info->labels - 1; i >= 0; i--) {
>> +        hdr[i] = mpls_entry_encode(tun_encap_info->label[i],
>> +                       dec.ttl, 0, bos);
>
> dec is never initialised in this function, so this will encode a 
> garbage ttl into the packet.
>
> This should instead be deriving the ttl from the IP packet, as Eric 
> did in his original patch.
>
Thanks for the pointer Robert. I will fix it.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in